netdev - Re: [net-next V10 PATCH 00/16] XDP redirect memory return API

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180417163930.5aa24de9@redhat.com>
Date:   Tue, 17 Apr 2018 16:39:30 +0200
From:   Jesper Dangaard Brouer <brouer@...hat.com>
To:     David Miller <davem@...emloft.net>
Cc:     alexei.starovoitov@...il.com, netdev@...r.kernel.org,
        bjorn.topel@...el.com, magnus.karlsson@...el.com,
        eugenia@...lanox.com, jasowang@...hat.com,
        john.fastabend@...il.com, eranbe@...lanox.com, saeedm@...lanox.com,
        galp@...lanox.com, borkmann@...earbox.net, tariqt@...lanox.com,
        brouer@...hat.com
Subject: Re: [net-next V10 PATCH 00/16] XDP redirect memory return API

On Tue, 17 Apr 2018 10:07:50 -0400 (EDT)
David Miller <davem@...emloft.net> wrote:

> From: Alexei Starovoitov <alexei.starovoitov@...il.com>
> Date: Tue, 17 Apr 2018 06:53:33 -0700
> 
> > looks like you forgot to include extra patch to fixup xdp_adjust_head()
> > helper. Otherwise reused xdp_frame in the top of that packet is leaking
> > kernel pointers into bpf program.
> > Could you please respin with that change included?  
> 
> Just in time, I was about to push this back out. :)
> 
> Jesper, please respin with Alexei's requested changes.

Your guys are torturing me!

-- 
Best regards,
  Jesper Dangaard Brouer
  MSc.CS, Principal Kernel Engineer at Red Hat
  LinkedIn: http://www.linkedin.com/in/brouer