netdev - Re: [PATCH RESEND net-next v2] KEYS: DNS: limit the length of option strings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20180417.134316.1413649044013070735.davem@davemloft.net>
Date:   Tue, 17 Apr 2018 13:43:16 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     ebiggers3@...il.com
Cc:     netdev@...r.kernel.org, keyrings@...r.kernel.org,
        mark.rutland@....com, ebiggers@...gle.com
Subject: Re: [PATCH RESEND net-next v2] KEYS: DNS: limit the length of
 option strings

From: Eric Biggers <ebiggers3@...il.com>
Date: Mon, 16 Apr 2018 14:29:22 -0700

> From: Eric Biggers <ebiggers@...gle.com>
> 
> Adding a dns_resolver key whose payload contains a very long option name
> resulted in that string being printed in full.  This hit the WARN_ONCE()
> in set_precision() during the printk(), because printk() only supports a
> precision of up to 32767 bytes:
> 
>     precision 1000000 too large
>     WARNING: CPU: 0 PID: 752 at lib/vsprintf.c:2189 vsnprintf+0x4bc/0x5b0
> 
> Fix it by limiting option strings (combined name + value) to a much more
> reasonable 128 bytes.  The exact limit is arbitrary, but currently the
> only recognized option is formatted as "dnserror=%lu" which fits well
> within this limit.
> 
> Also ratelimit the printks.
> 
> Reproducer:
> 
>     perl -e 'print "#", "A" x 1000000, "\x00"' | keyctl padd dns_resolver desc @s
> 
> This bug was found using syzkaller.
> 
> Reported-by: Mark Rutland <mark.rutland@....com>
> Fixes: 4a2d789267e0 ("DNS: If the DNS server returns an error, allow that to be cached [ver #2]")
> Signed-off-by: Eric Biggers <ebiggers@...gle.com>

Applied, thanks.