netdev - Re: [PATCH iproute2] utils: Do not reset family for default, any, all addresses

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180416170138.6ce01b6d@xeon-e3>
Date:   Mon, 16 Apr 2018 17:01:38 -0700
From:   Stephen Hemminger <stephen@...workplumber.org>
To:     David Ahern <dsahern@...il.com>
Cc:     netdev@...r.kernel.org, whissi@...too.org,
        Serhey Popovych <serhe.popovych@...il.com>
Subject: Re: [PATCH iproute2] utils: Do not reset family for default, any,
 all addresses

On Fri, 13 Apr 2018 09:36:33 -0700
David Ahern <dsahern@...il.com> wrote:

> Thomas reported a change in behavior with respect to autodectecting
> address families. Specifically, 'ip ro add default via fe80::1'
> syntax was failing to treat fe80::1 as an IPv6 address as it did in
> prior releases. The root causes appears to be a change in family when
> the default keyword is parsed.
> 
> 'default', 'any' and 'all' are relevant outside of AF_INET. Leave the
> family arg as is for these when setting addr.
> 
> Fixes: 93fa12418dc6 ("utils: Always specify family and ->bytelen in get_prefix_1()")
> Reported-by: Thomas Deutschmann <whissi@...too.org>
> Signed-off-by: David Ahern <dsahern@...il.com>
> Cc: Serhey Popovych <serhe.popovych@...il.com>

Looks good, thanks for fixing.
Applied