netdev - Re: [PATCH net,stable] tun: fix vlan packet truncation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87bmehftvh.fsf@miraculix.mork.no>
Date:   Tue, 17 Apr 2018 22:41:38 +0200
From:   Bjørn Mork <bjorn@...k.no>
To:     David Miller <davem@...emloft.net>
Cc:     netdev@...r.kernel.org, jasowang@...hat.com
Subject: Re: [PATCH net,stable] tun: fix vlan packet truncation

David Miller <davem@...emloft.net> writes:

> The VLAN business might be bogus, and needs to be removed.
>
> However, the pskb_trim() has to stay in some form.  I think this is what
> Jason is trying to say.
>
> The semantics of running a BPF program is that the program returns the
> desired packet length.  We must truncate the packet to the length
> returned by the BPF program, therefore.

Right. That's obvious when I look closer at it. Sorry for being so
slow...  New version coming up.


Bjørn