netdev - Re: [PATCH 08/10] net: ax88796: Make reset more robust on AX88796B

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <58605.92.192.176.127.1523942290.webmail@webmail.zedat.fu-berlin.de>
Date:   Tue, 17 Apr 2018 07:18:10 +0200
From:   "Michael Karcher" <michael.karcher@...berlin.de>
To:     "Andrew Lunn" <andrew@...n.ch>
Cc:     "Michael Schmitz" <schmitzmic@...il.com>, netdev@...r.kernel.org,
        "Linux/m68k" <linux-m68k@...r.kernel.org>,
        "Michael Karcher" <michael.karcher@...berlin.de>,
        "John Paul Adrian Glaubitz" <glaubitz@...sik.fu-berlin.de>,
        "Michael Karcher" <kernel@...rcher.dialup.fu-berlin.de>
Subject: Re: [PATCH 08/10] net: ax88796: Make reset more robust on AX88796B

[Andrew, sorry for the dup. I did hit reply-to-auhor instead of
reply-to-all first.]

Andrew Lunn schrieb:
>> > This should really be fixed in the PHY driver, not the MAC.
>>
>> OK - do you want this separate, or as part of this series? Might have
>> a few side effects on more commonly used hardware, perhaps?
>
> Hi Michael
>
> What PHY driver is used?
The ax88796b comes with its own integrated (buggy) PHY needing this
workaround. This PHY has its own ID which is not known by Linux, so it is
using the genphy driver as fallback.

> In the driver you can implement a .soft_reset
> function which first does the dummy write, and then uses
> genphy_soft_reset() to do the actual reset.
We could do that - but I dont't see the point in creating a PHY driver
that is only ever used by this MAC driver, just to add a single line to
the genphy driver. If the same PHY might be used with a different MAC,
you definitely would have a point there, though.

Kind regards,
  Michael Karcher