netdev - Re: [Regression] net/phy/micrel.c v4.9.94

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180418124303.GD31643@lunn.ch>
Date:   Wed, 18 Apr 2018 14:43:03 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Chris Ruehl <chris.ruehl@...ys.com.hk>
Cc:     f.fainelli@...il.com, netdev@...r.kernel.org
Subject: Re: [Regression] net/phy/micrel.c v4.9.94

> If I look at the patch I think it should call kszphy_config_init() not _reset()
> in the resume function:
> 
> 
> @@ -715,8 +723,14 @@ static int kszphy_suspend(struct phy_device *phydev)
> 
>  static int kszphy_resume(struct phy_device *phydev)
>  {
> +	int ret;
> +
>  	genphy_resume(phydev);
> 
> -	ret = kszphy_config_reset(phydev);
> +       ret = kszphy_config_init(phydev);
> +	if (ret)
> +		return ret;
> +
> 

Hi Chris

I think there has been a patch for this posted. If i remember
correctly, the PHY you have does not call probe, hence phydev->priv is
a NULL pointer, so priv->rmii_ref_clk_sel does not work.

It would be good to find the patch and make sure it has been accepted,
and marked for stable.

    Andrew