netdev - Re: [PATCH 0/8] ipconfig: NTP server support, bug fixes, documentation improvements

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20180418.135909.1521396191656904961.davem@davemloft.net>
Date:   Wed, 18 Apr 2018 13:59:09 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     chris@...isn.me.uk
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH 0/8] ipconfig: NTP server support, bug fixes,
 documentation improvements

From: Chris Novakovic <chris@...isn.me.uk>
Date: Tue, 17 Apr 2018 21:58:22 +0100

>  - Patch #7 allows for NTP servers to be configured (manually on the
>    kernel command line or automatically via DHCP), enabling systems with
>    an NFS root filesystem to synchronise their clock before mounting
>    their root filesystem.

I think a plain file named /proc/net/ntp is quite confusing.  It doesn't
give any indication that it's a special file populated only by ipconfig
and not some general NTP thing the kernel is doing.

I would suggest creating a subdirectory like /proc/net/ipconfig or similar
to put such files.  Then the use and meaning is clear.

Also, as noted please remove patch 8 updating CREDITS, this really isn't
done any more.