netdev - Re: [PATCH RFC net-next 06/11] udp: add gso support to virtual devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 17 Apr 2018 23:27:33 -0400
From:   Willem de Bruijn <willemdebruijn.kernel@...il.com>
To:     Dimitris Michailidis <dmichail@...gle.com>
Cc:     netdev <netdev@...r.kernel.org>,
        Willem de Bruijn <willemb@...gle.com>
Subject: Re: [PATCH RFC net-next 06/11] udp: add gso support to virtual devices

On Tue, Apr 17, 2018 at 8:43 PM, Dimitris Michailidis
<dmichail@...gle.com> wrote:
> On Tue, Apr 17, 2018 at 1:00 PM, Willem de Bruijn
> <willemdebruijn.kernel@...il.com> wrote:
>> From: Willem de Bruijn <willemb@...gle.com>
>>
>> Virtual devices such as tunnels and bonding can handle large packets.
>> Only segment packets when reaching a physical or loopback device.
>>
>> Signed-off-by: Willem de Bruijn <willemb@...gle.com>
>> ---
>>  include/linux/netdev_features.h | 3 +++
>>  1 file changed, 3 insertions(+)
>>
>> diff --git a/include/linux/netdev_features.h b/include/linux/netdev_features.h
>> index 35b79f47a13d..1e4883bb02a7 100644
>> --- a/include/linux/netdev_features.h
>> +++ b/include/linux/netdev_features.h
>> @@ -80,6 +80,7 @@ enum {
>>
>>         NETIF_F_GRO_HW_BIT,             /* Hardware Generic receive offload */
>>         NETIF_F_HW_TLS_RECORD_BIT,      /* Offload TLS record */
>> +       NETIF_F_GSO_UDP_L4_BIT,         /* UDP payload GSO (not UFO) */
>
> Please add an entry for the new flag to
> net/core/ethtool.c:netdev_features_strings
> and a description to Documentation/networking/netdev-features.txt.

Will do. I initially wrote this as a transparent kernel-internal feature,
but indeed it should be observable and configurable.