netdev - Re: [PATCH net-next] net/ipv6: Fix ip6_convert

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1c2a878f-2e8a-ecd2-f927-1f90bafff0d9@cumulusnetworks.com>
Date:   Thu, 19 Apr 2018 10:46:18 -0600
From:   David Ahern <dsa@...ulusnetworks.com>
To:     Eric Dumazet <edumazet@...gle.com>,
        "David S . Miller" <davem@...emloft.net>
Cc:     netdev <netdev@...r.kernel.org>,
        Eric Dumazet <eric.dumazet@...il.com>
Subject: Re: [PATCH net-next] net/ipv6: Fix ip6_convert_metrics() bug

On 4/19/18 10:14 AM, Eric Dumazet wrote:
> If ip6_convert_metrics() fails to allocate memory, it should not
> overwrite rt->fib6_metrics or we risk a crash later as syzbot found.
> 

...

> 
> Fixes: d4ead6b34b67 ("net/ipv6: move metrics from dst to rt6_info")
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> Cc: David Ahern <dsa@...ulusnetworks.com>
> Reported-by: syzbot <syzkaller@...glegroups.com>
> ---
>  net/ipv6/route.c | 20 +++++++++-----------
>  1 file changed, 9 insertions(+), 11 deletions(-)

Acked-by: David Ahern <dsa@...ulusnetworks.com>

Thanks for fixing.