netdev - Re: [PATCH net-next 01/11] net: phy_ mdio-gpio: Fixup , which should be ;

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20180419.160053.1276318008387713277.davem@davemloft.net>
Date:   Thu, 19 Apr 2018 16:00:53 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     andrew@...n.ch
Cc:     netdev@...r.kernel.org, f.fainelli@...il.com,
        linus.walleij@...aro.org
Subject: Re: [PATCH net-next 01/11] net: phy_ mdio-gpio: Fixup , which
 should be ;

From: Andrew Lunn <andrew@...n.ch>
Date: Thu, 19 Apr 2018 01:02:49 +0200

> @@ -161,7 +161,7 @@ static struct mii_bus *mdio_gpio_bus_init(struct device *dev,
>  	if (!new_bus)
>  		goto out;
>  
> -	new_bus->name = "GPIO Bitbanged MDIO",
> +	new_bus->name = "GPIO Bitbanged MDIO";

Would be so great to find a way to automatically detect these somehow.

Yes, they are useful when controlling evaluation in weird ways in
macros etc.  However most of the time if a ',' is used in a context
where a ';' also works, it's unintentional.