netdev - Re: [PATCH] net: net_cls: remove a NULL check for css_cls

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20180420.103725.37816458687606953.davem@davemloft.net>
Date:   Fri, 20 Apr 2018 10:37:25 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     lirongqing@...du.com
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH] net: net_cls: remove a NULL check for css_cls_state

From: Li RongQing <lirongqing@...du.com>
Date: Thu, 19 Apr 2018 12:59:21 +0800

> The input of css_cls_state() is impossible to NULL except
> cgrp_css_online, so simplify it
> 
> Signed-off-by: Li RongQing <lirongqing@...du.com>

I don't view this as an improvement.  Just let the helper always check
NULL and that way there are less situations to audit.

And it's not like this is a critical fast path either.

I'm not applying this, sorry.