netdev - Re: [PATCH] net: qrtr: Expose tunneling endpoint to user space

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180420.104020.570006839387571888.davem@davemloft.net>
Date:   Fri, 20 Apr 2018 10:40:20 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     bjorn.andersson@...aro.org
Cc:     linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
        linux-arm-msm@...r.kernel.org, clew@...eaurora.org
Subject: Re: [PATCH] net: qrtr: Expose tunneling endpoint to user space

From: Bjorn Andersson <bjorn.andersson@...aro.org>
Date: Wed, 18 Apr 2018 22:03:46 -0700

> +struct qrtr_tun {
> +	struct qrtr_endpoint ep;
> +
> +	struct mutex queue_lock;
> +	struct sk_buff_head queue;
> +	wait_queue_head_t readq;
> +};

The queue lock is surperfluous.  sk_buff_head and all of the helpers you
are using does it's own locking.  So you are essentially using two sets
of locks to protect the same object.