netdev - Re: [PATCH net-next] tun: do not compute the rxhash, if not needed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180420.115147.1711381333310778661.davem@davemloft.net>
Date:   Fri, 20 Apr 2018 11:51:47 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     pabeni@...hat.com
Cc:     netdev@...r.kernel.org, jasowang@...hat.com
Subject: Re: [PATCH net-next] tun: do not compute the rxhash, if not needed

From: Paolo Abeni <pabeni@...hat.com>
Date: Fri, 20 Apr 2018 13:18:16 +0200

> Currently, the tun driver, in absence of an eBPF steering program,
> always compute the rxhash in its rx path, even when such value
> is later unused due to additional checks (
> 
> This changeset moves the all the related checks just before the
> __skb_get_hash_symmetric(), so that the latter is no more computed
> when unneeded.
> 
> Also replace an unneeded RCU section with rcu_access_pointer().
> 
> Signed-off-by: Paolo Abeni <pabeni@...hat.com>

Applied, thank you.