netdev - Re: [PATCH RFC iptables] iptables: Per-net ns lock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180420105034.7qwwr3lrh7w7xlh4@breakpoint.cc>
Date:   Fri, 20 Apr 2018 12:50:34 +0200
From:   Florian Westphal <fw@...len.de>
To:     Kirill Tkhai <ktkhai@...tuozzo.com>
Cc:     netdev@...r.kernel.org, pablo@...filter.org, rstoyanov1@...il.com,
        fw@...len.de, ptikhomirov@...tuozzo.com, avagin@...tuozzo.com
Subject: Re: [PATCH RFC iptables] iptables: Per-net ns lock

Kirill Tkhai <ktkhai@...tuozzo.com> wrote:
> Pablo, Florian, could you please provide comments on this?
> 
> On 09.04.2018 19:55, Kirill Tkhai wrote:
> > In CRIU and LXC-restore we met the situation,
> > when iptables in container can't be restored
> > because of permission denied:
> > 
> > https://github.com/checkpoint-restore/criu/issues/469
> > 
> > Containers want to restore their own net ns,
> > while they may have no their own mnt ns.
> > This case they share host's /run/xtables.lock
> > file, but they may not have permission to open
> > it.
> > 
> > Patch makes /run/xtables.lock to be per-namespace,
> > i.e., to refer to the caller task's net ns.

It looks ok to me but then again the entire userspace
lock thing is a ugly band aid :-/