netdev - Re: [PATCH 3/3] xen blkback: add fault injection facility

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <403573a8-daeb-2e0e-fa31-e9bd160557fc@amazon.com>
Date:   Fri, 20 Apr 2018 14:53:13 +0200
From:   <staskins@...zon.com>
To:     Juergen Gross <jgross@...e.com>
CC:     <jakub.kicinski@...ronome.com>, <hpa@...or.com>,
        <mcroce@...hat.com>, <tglx@...utronix.de>, <ggarcia@...a.uab.cat>,
        <daniel@...earbox.net>, <x86@...nel.org>, <mingo@...hat.com>,
        <xen-devel@...ts.xenproject.org>, <axboe@...nel.dk>,
        <konrad.wilk@...cle.com>, <amir.jer.levy@...el.com>,
        <paul.durrant@...rix.com>, <stefanha@...hat.com>,
        <dsa@...ulusnetworks.com>, <boris.ostrovsky@...cle.com>,
        <linux-block@...r.kernel.org>, <wei.liu2@...rix.com>,
        <netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <davem@...emloft.net>, <dwmw@...zon.co.uk>, <roger.pau@...rix.com>
Subject: Re: [PATCH 3/3] xen blkback: add fault injection facility

On 04/20/18 13:28, Juergen Gross wrote:
> On 20/04/18 12:47, Stanislav Kinsburskii wrote:
>> This patch adds wrapper helpers around generic Xen fault inject
>> facility.
>> The major reason is to keep all the module fault injection directories
>> in a dedicated subdirectory instead of Xen fault inject root.
>>
>> IOW, when using these helpers, per-device and named by device name
>> fault injection control directories will appear under the following
>> directory:
>> - /sys/kernel/debug/xen/fault_inject/xen-blkback/
>> instead of:
>> - /sys/kernel/debug/xen/fault_inject/
>>
>> Signed-off-by: Stanislav Kinsburskii <staskins@...zon.com>
>> CC: Jens Axboe <axboe@...nel.dk>
>> CC: Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>
>> CC: "Roger Pau Monné" <roger.pau@...rix.com>
>> CC: linux-kernel@...r.kernel.org
>> CC: linux-block@...r.kernel.org
>> CC: xen-devel@...ts.xenproject.org
>> CC: Stanislav Kinsburskii <staskins@...zon.com>
>> CC: David Woodhouse <dwmw@...zon.co.uk>
> This is an exact copy of the netback patch apart from the names.
>
> I don't like adding multiple copies of the same coding to the tree.

Sure, will dedupplicate this.

>
> Juergen
>

Amazon Development Center Germany GmbH
Berlin - Dresden - Aachen
main office: Krausenstr. 38, 10117 Berlin
Geschaeftsfuehrer: Dr. Ralf Herbrich, Christian Schlaeger
Ust-ID: DE289237879
Eingetragen am Amtsgericht Charlottenburg HRB 149173 B