netdev - Re: [PATCH iproute2] iplink_geneve: correct size of message to avoid spurious errors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CALDO+SY_1h0_6-VF6+zh=xFV0DMw5xnUgA7aB2f7FS3V4Ko=GQ@mail.gmail.com>
Date:   Fri, 20 Apr 2018 21:14:19 -0700
From:   William Tu <u9012063@...il.com>
To:     Jakub Kicinski <jakub.kicinski@...ronome.com>
Cc:     Stephen Hemminger <stephen@...workplumber.org>,
        David Ahern <dsahern@...il.com>, oss-drivers@...ronome.com,
        Linux Kernel Network Developers <netdev@...r.kernel.org>
Subject: Re: [PATCH iproute2] iplink_geneve: correct size of message to avoid
 spurious errors

On Wed, Apr 18, 2018 at 11:06 AM, Jakub Kicinski
<jakub.kicinski@...ronome.com> wrote:
> Commit 6c4b672738ac ("iplink_geneve: Get rid of inet_get_addr()")
> inadvertently changed the parameter to addattr_l() resulting in:
>
> addattr_l ERROR: message exceeded bound of 4
>
> when remote is specified.
>
> Fixes: 6c4b672738ac ("iplink_geneve: Get rid of inet_get_addr()")
> Signed-off-by: Jakub Kicinski <jakub.kicinski@...ronome.com>
> Reviewed-by: Quentin Monnet <quentin.monnet@...ronome.com>
> ---

Thanks. We also hit this issue when creating geneve tunnel.

Acked-by: William Tu <u9012063@...il.com>