netdev - Re: [PATCH 15/39] acpi/battery: simplify procfs code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJZ5v0gRw8P8KL12QKMuSjyePxWn71LB+s8ephF2a4-Ns234NQ@mail.gmail.com>
Date:   Sun, 22 Apr 2018 11:42:08 +0200
From:   "Rafael J. Wysocki" <rafael@...nel.org>
To:     Christoph Hellwig <hch@....de>
Cc:     Andrew Morton <akpm@...ux-foundation.org>,
        Alexander Viro <viro@...iv.linux.org.uk>,
        Alexey Dobriyan <adobriyan@...il.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Jiri Slaby <jslaby@...e.com>, Corey Minyard <minyard@....org>,
        Alessandro Zummo <a.zummo@...ertech.it>,
        Alexandre Belloni <alexandre.belloni@...tlin.com>,
        ACPI Devel Maling List <linux-acpi@...r.kernel.org>,
        drbd-dev@...ts.linbit.com, linux-ide@...r.kernel.org,
        netdev <netdev@...r.kernel.org>, linux-rtc@...r.kernel.org,
        megaraidlinux.pdl@...adcom.com,
        "open list:TARGET SUBSYSTEM" <linux-scsi@...r.kernel.org>,
        devel@...verdev.osuosl.org, linux-afs@...ts.infradead.org,
        Ext4 Developers List <linux-ext4@...r.kernel.org>,
        jfs-discussion@...ts.sourceforge.net,
        netfilter-devel@...r.kernel.org,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 15/39] acpi/battery: simplify procfs code

On Thu, Apr 19, 2018 at 2:41 PM, Christoph Hellwig <hch@....de> wrote:
> Use remove_proc_subtree to remove the whole subtree on cleanup, and
> unwind the registration loop into individual calls.  Switch to use
> proc_create_seq where applicable.
>
> Signed-off-by: Christoph Hellwig <hch@....de>

It is OK AFAICS.

Reviewed-by: Rafael J. Wysocki <rafael.j.wysocki@...el.com>