netdev - Re: [PATCH net] strparser: Do not call mod_delayed_work with a timeout of LONG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sun, 22 Apr 2018 21:10:49 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     doronrk@...com
Cc:     tj@...nel.org, netdev@...r.kernel.org
Subject: Re: [PATCH net] strparser: Do not call mod_delayed_work with a
 timeout of LONG_MAX

From: Doron Roberts-Kedes <doronrk@...com>
Date: Fri, 20 Apr 2018 12:11:11 -0700

> struct sock's sk_rcvtimeo is initialized to
> LONG_MAX/MAX_SCHEDULE_TIMEOUT in sock_init_data. Calling
> mod_delayed_work with a timeout of LONG_MAX causes spurious execution of
> the work function. timer->expires is set equal to jiffies + LONG_MAX.
> When timer_base->clk falls behind the current value of jiffies,
> the delta between timer_base->clk and jiffies + LONG_MAX causes the
> expiration to be in the past. Returning early from strp_start_timer if
> timeo == LONG_MAX solves this problem.
> 
> Found while testing net/tls_sw recv path.
> 
> Fixes: 43a0c6751a322847 ("strparser: Stream parser for messages")
> Reviewed-by: Tejun Heo <tj@...nel.org>
> Signed-off-by: Doron Roberts-Kedes <doronrk@...com>

Applied and queued up for -stable, thanks.