netdev - Re: [PATCH net-next, v2] Per interface IPv4 stats (CONFIG_IP_IFSTATS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180423.100756.356745580041655992.davem@davemloft.net>
Date:   Mon, 23 Apr 2018 10:07:56 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     ssuryaextr@...il.com
Cc:     netdev@...r.kernel.org, ja@....bg
Subject: Re: [PATCH net-next, v2] Per interface IPv4 stats
 (CONFIG_IP_IFSTATS_TABLE)

From: Stephen Suryaputra <ssuryaextr@...il.com>
Date: Fri, 20 Apr 2018 19:52:43 -0400

> This is enhanced from the proposed patch by Igor Maravic in 2011 to
> support per interface IPv4 stats. The enhancement is mainly adding a
> kernel configuration option CONFIG_IP_IFSTATS_TABLE.
> 
> Changes from v1:
> - Count input statistics in the input device (per Julian Anastasov).
> - Changes so that the existing per interface IPv6 stats aren't affected
>   when the option isn't enabled.
> - Restore the order of calling ipv4_proc_init().
> 
> Signed-off-by: Stephen Suryaputra <ssuryaextr@...il.com>

Using a config option to control this is not appropriate.

Every distribution is going to enable this option in their kernels.

If the thinking is that a controversial semantic change can be added
as long as it can be disabled by a kernel config option, then sorry I
have to inform you that is not really how this kind of situation
works.

I'm not applying this patch, sorry.