netdev - Re: [PATCH net] bonding: do not set slave_dev npinfo before slave_enable_netpoll in bond

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180423.115522.1779137809989261376.davem@davemloft.net>
Date:   Mon, 23 Apr 2018 11:55:22 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     lucien.xin@...il.com
Cc:     netdev@...r.kernel.org, andy@...yhouse.net, jiri@...nulli.us,
        xiyou.wangcong@...il.com
Subject: Re: [PATCH net] bonding: do not set slave_dev npinfo before
 slave_enable_netpoll in bond_enslave

From: Xin Long <lucien.xin@...il.com>
Date: Sun, 22 Apr 2018 19:11:50 +0800

> After Commit 8a8efa22f51b ("bonding: sync netpoll code with bridge"), it
> would set slave_dev npinfo in slave_enable_netpoll when enslaving a dev
> if bond->dev->npinfo was set.
> 
> However now slave_dev npinfo is set with bond->dev->npinfo before calling
> slave_enable_netpoll. With slave_dev npinfo set, __netpoll_setup called
> in slave_enable_netpoll will not call slave dev's .ndo_netpoll_setup().
> It causes that the lower dev of this slave dev can't set its npinfo.
> 
> One way to reproduce it:
> 
>   # modprobe bonding
>   # brctl addbr br0
>   # brctl addif br0 eth1
>   # ifconfig bond0 192.168.122.1/24 up
>   # ifenslave bond0 eth2
>   # systemctl restart netconsole
>   # ifenslave bond0 br0
>   # ifconfig eth2 down
>   # systemctl restart netconsole
> 
> The netpoll won't really work.
> 
> This patch is to remove that slave_dev npinfo setting in bond_enslave().
> 
> Fixes: 8a8efa22f51b ("bonding: sync netpoll code with bridge")
> Signed-off-by: Xin Long <lucien.xin@...il.com>

Applied and queued up for -stable, thanks.