netdev - Re: [PATCH net-next 0/6] net: Extend availability of PHY statistics

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <52c6b673-857c-e252-1a62-5e74effd6781@gmail.com>
Date:   Mon, 23 Apr 2018 10:46:52 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     netdev@...r.kernel.org, "David S. Miller" <davem@...emloft.net>
Cc:     Andrew Lunn <andrew@...n.ch>,
        Vivien Didelot <vivien.didelot@...oirfairelinux.com>,
        cphealy@...il.com
Subject: Re: [PATCH net-next 0/6] net: Extend availability of PHY statistics

On 04/21/2018 11:55 AM, Florian Fainelli wrote:
> Hi all,
> 
> This patch series adds support for retrieving PHY statistics with DSA switches
> when the CPU port uses a PHY to PHY connection (as opposed to MAC to MAC).
> To get there a number of things are done:
> 
> - first we move the code dealing with PHY statistics outside of net/core/ethtool.c
>   and create helper functions since the same code will be reused
> - then we allow network device drivers to provide an ethtool_get_phy_stats callback
>   when the standard PHY library helpers are not suitable
> - we update the DSA functions dealing with ethtool operations to get passed a
>   stringset instead of assuming ETH_SS_STATS like they currently do
> - then we provide a set of standard helpers within DSA as a framework and add
>   the plumbing to allow retrieving the PHY statistics of the CPU port(s)
> - finally plug support for retrieving such PHY statistics with the b53 driver

David, there will be a v2 coming not just to fix the kbuild reported
issues, but also another one reported privately, thank you.

> 
> Florian Fainelli (6):
>   net: Move PHY statistics code into PHY library helpers
>   net: Allow network devices to have PHY statistics
>   net: dsa: Pass stringset to ethtool operations
>   net: dsa: Add helper function to obtain PHY device of a given port
>   net: dsa: Allow providing PHY statistics from CPU port
>   net: dsa: b53: Add support for reading PHY statistics
> 
>  drivers/net/dsa/b53/b53_common.c       | 66 ++++++++++++++++++++++---
>  drivers/net/dsa/b53/b53_priv.h         |  6 ++-
>  drivers/net/dsa/bcm_sf2.c              |  1 +
>  drivers/net/dsa/dsa_loop.c             | 11 ++++-
>  drivers/net/dsa/lan9303-core.c         | 11 ++++-
>  drivers/net/dsa/microchip/ksz_common.c | 11 ++++-
>  drivers/net/dsa/mt7530.c               | 11 ++++-
>  drivers/net/dsa/mv88e6xxx/chip.c       | 10 +++-
>  drivers/net/dsa/qca8k.c                | 10 +++-
>  drivers/net/phy/phy.c                  | 48 ++++++++++++++++++
>  include/linux/ethtool.h                |  5 ++
>  include/linux/phy.h                    |  4 ++
>  include/net/dsa.h                      | 12 ++++-
>  net/core/ethtool.c                     | 61 ++++++++---------------
>  net/dsa/master.c                       | 41 +++++++++++++---
>  net/dsa/port.c                         | 90 +++++++++++++++++++++++++++++-----
>  net/dsa/slave.c                        |  5 +-
>  17 files changed, 320 insertions(+), 83 deletions(-)
> 


-- 
Florian