netdev - Re: [PATCH bpf-next v5 10/10] tools/bpf: add a test for bpf_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180423194741.cyhu4r3yj42neynf@ast-mbp>
Date:   Mon, 23 Apr 2018 13:47:43 -0600
From:   Alexei Starovoitov <alexei.starovoitov@...il.com>
To:     Yonghong Song <yhs@...com>
Cc:     ast@...com, daniel@...earbox.net, netdev@...r.kernel.org,
        ecree@...arflare.com, kernel-team@...com
Subject: Re: [PATCH bpf-next v5 10/10] tools/bpf: add a test for
 bpf_get_stack with tracepoint prog

On Mon, Apr 23, 2018 at 10:54:17AM -0700, Yonghong Song wrote:
> The test_stacktrace_map and test_stacktrace_build_id are
> enhanced to call bpf_get_stack in the helper to get the
> stack trace as well.  The stack traces from bpf_get_stack
> and bpf_get_stackid are compared to ensure that for the
> same stack as represented as the same hash, their ip addresses
> or build id's must be the same.
> 
> Signed-off-by: Yonghong Song <yhs@...com>
...
>  /* taken from /sys/kernel/debug/tracing/events/sched/sched_switch/format */
> @@ -44,7 +51,10 @@ struct sched_switch_args {
>  SEC("tracepoint/sched/sched_switch")
>  int oncpu(struct sched_switch_args *ctx)
>  {
> +	__u32 max_len = PERF_MAX_STACK_DEPTH * sizeof(__u64);
>  	__u32 key = 0, val = 0, *value_p;
> +	void *stack_p;
> +

nit: unnecessary extra empty line.
otherwise
Acked-by: Alexei Starovoitov <ast@...nel.org>