netdev - Re: [PATCH net] team: check team dev npinfo when adding a port only

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CADvbK_c9tWCpkvK7SddaG=QsyU3uAZt=rVEZc7e2d=yC4s_BGA@mail.gmail.com>
Date:   Mon, 23 Apr 2018 16:46:13 +0800
From:   Xin Long <lucien.xin@...il.com>
To:     kbuild test robot <lkp@...el.com>
Cc:     kbuild-all@...org, network dev <netdev@...r.kernel.org>,
        davem <davem@...emloft.net>, Jiri Pirko <jiri@...nulli.us>,
        stephen hemminger <stephen@...workplumber.org>
Subject: Re: [PATCH net] team: check team dev npinfo when adding a port only

On Mon, Apr 23, 2018 at 1:40 PM, Xin Long <lucien.xin@...il.com> wrote:
> On Mon, Apr 23, 2018 at 12:20 PM, kbuild test robot <lkp@...el.com> wrote:
>> Hi Xin,
>>
>> Thank you for the patch! Yet something to improve:
>>
>> [auto build test ERROR on net/master]
>>
>> url:    https://github.com/0day-ci/linux/commits/Xin-Long/team-check-team-dev-npinfo-when-adding-a-port-only/20180423-114310
>> config: i386-randconfig-x071-201816 (attached as .config)
>> compiler: gcc-7 (Debian 7.3.0-16) 7.3.0
>> reproduce:
>>         # save the attached .config to linux build tree
>>         make ARCH=i386
>>
>> All errors (new ones prefixed by >>):
>>
>>    drivers/net/team/team.c: In function 'team_port_add':
>>>> drivers/net/team/team.c:1221:15: error: 'struct net_device' has no member named 'npinfo'
>>      if (team->dev->npinfo) {
>>                   ^~
> Oops, this is different from bonding, we probably should
> just revert 0fb52a27a04a ("team: cleanup netpoll clode")
> for this fix.
or do the same as bridge netpoll does.

+static int team_port_enable_netpoll(struct team *team, struct team_port *port)
+{
+       if (!team->dev->npinfo)
+               return 0;
+
+       return __team_port_enable_netpoll(port);
+}

which looks better.