netdev - Re: [PATCH bpf-next] bpf: fix virtio-net's length calc for XDP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <cdf0ba67-e420-c565-fcc1-2ce3e7697967@iogearbox.net>
Date:   Mon, 23 Apr 2018 11:30:21 +0200
From:   Daniel Borkmann <daniel@...earbox.net>
To:     Jason Wang <jasowang@...hat.com>,
        "Nikita V. Shirokov" <tehnerd@...nerd.com>,
        Alexei Starovoitov <ast@...nel.org>,
        "Michael S. Tsirkin" <mst@...hat.com>
Cc:     netdev@...r.kernel.org, David Ahern <dsahern@...il.com>
Subject: Re: [PATCH bpf-next] bpf: fix virtio-net's length calc for XDP_PASS

On 04/23/2018 08:33 AM, Jason Wang wrote:
> On 2018年04月23日 12:16, Nikita V. Shirokov wrote:
>> In commit 6870de435b90 ("bpf: make virtio compatible w/
>> bpf_xdp_adjust_tail") i didn't account for vi->hdr_len during new
>> packet's length calculation after bpf_prog_run in receive_mergeable.
>> because of this all packets, if they were passed to the kernel,
>> were truncated by 12 bytes.
>>
>> Fixes:6870de435b90 ("bpf: make virtio compatible w/ bpf_xdp_adjust_tail")
>> Reported-by: David Ahern <dsahern@...il.com>
>>
>> Signed-off-by: Nikita V. Shirokov <tehnerd@...nerd.com>
[...]
> 
> Acked-by: Jason Wang <jasowang@...hat.com>

Applied to bpf-next, thanks everyone!