netdev - Re: [PATCH net-next] qed: Fix copying 2 strings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180424.140007.4712978535021934.davem@davemloft.net>
Date:   Tue, 24 Apr 2018 14:00:07 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     denis.bolotin@...ium.com
Cc:     netdev@...r.kernel.org, ariel.elior@...ium.com
Subject: Re: [PATCH net-next] qed: Fix copying 2 strings

From: Denis Bolotin <denis.bolotin@...ium.com>
Date: Tue, 24 Apr 2018 15:32:53 +0300

> The strscpy() was a recent fix (net: qed: use correct strncpy() size) to
> prevent passing the length of the source buffer to strncpy() and guarantee
> null termination.
> It misses the goal of overwriting only the first 3 characters in
> "???_BIG_RAM" and "???_RAM" while keeping the rest of the string.
> Use strncpy() with the length of 3, without null termination.
> 
> Signed-off-by: Denis Bolotin <denis.bolotin@...ium.com>
> Signed-off-by: Ariel Elior <ariel.elior@...ium.com>

Applied, thank you.