netdev - Re: [PATCH net-next 2/2 v1] netns: isolate seqnums to use per-netns locks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180424204558.GA16013@gmail.com>
Date:   Tue, 24 Apr 2018 22:45:59 +0200
From:   Christian Brauner <christian.brauner@...onical.com>
To:     David Miller <davem@...emloft.net>
Cc:     ebiederm@...ssion.com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, avagin@...tuozzo.com,
        ktkhai@...tuozzo.com, serge@...lyn.com, gregkh@...uxfoundation.org
Subject: Re: [PATCH net-next 2/2 v1] netns: isolate seqnums to use per-netns
 locks

On Tue, Apr 24, 2018 at 03:39:25PM -0400, David Miller wrote:
> From: Christian Brauner <christian.brauner@...ntu.com>
> Date: Mon, 23 Apr 2018 12:24:43 +0200
> 
> > +	#ifdef CONFIG_NET
> > +		seqnum = get_ns_uevent_seqnum_by_vpid();
> > +	#else
> > +		seqnum = uevent_seqnum;
> > +	#endif
> 
> Please don't indend the code like this.
> 
> By indenting the CPP directives, which should be at column zero, the
> actual code became double indented.

Ah, sorry. Sent v2 with the indendation fixed just now.

Thanks!
Christian