netdev - Re: [PATCH V6 net-next 08/15] net/tls: Support TLS device offload with IPv6

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180423.205606.1357960781269124348.davem@davemloft.net>
Date:   Mon, 23 Apr 2018 20:56:06 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     borisp@...lanox.com
Cc:     netdev@...r.kernel.org, saeedm@...lanox.com, davejwatson@...com,
        ktkhai@...tuozzo.com, ilyal@...lanox.com
Subject: Re: [PATCH V6 net-next 08/15] net/tls: Support TLS device offload
 with IPv6

From: Boris Pismenny <borisp@...lanox.com>
Date: Sun, 22 Apr 2018 18:19:50 +0300

> @@ -97,13 +102,57 @@ static void tls_device_queue_ctx_destruction(struct tls_context *ctx)
>  	spin_unlock_irqrestore(&tls_device_lock, flags);
>  }
>  
> +#if IS_ENABLED(CONFIG_IPV6)
> +static struct net_device *ipv6_get_netdev(struct sock *sk)
> +{
> +	struct net_device *dev = NULL;
> +	struct inet_sock *inet = inet_sk(sk);
> +	struct ipv6_pinfo *np = inet6_sk(sk);
> +	struct flowi6 _fl6, *fl6 = &_fl6;
> +	struct dst_entry *dst;

Ugh, please use sk->sk_dst_cache->dev and avoid all of the unnecessary
work.

Thank you.