netdev - Re: [PATCH 1/1] Revert "rds: ib: add error handle"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <66130D36-2987-416A-AF31-2BB9001E0036@oracle.com>
Date:   Tue, 24 Apr 2018 13:10:24 +0200
From:   Håkon Bugge <haakon.bugge@...cle.com>
To:     Santosh Shilimkar <santosh.shilimkar@...cle.com>
Cc:     Zhu Yanjun <yanjun.zhu@...cle.com>,
        OFED mailing list <linux-rdma@...r.kernel.org>,
        rds-devel@....oracle.com, davem@...emloft.net,
        netdev@...r.kernel.org, Dag Moxnes <dag.moxnes@...cle.com>
Subject: Re: [PATCH 1/1] Revert "rds: ib: add error handle"



> On 24 Apr 2018, at 05:27, santosh.shilimkar@...cle.com wrote:
> 
> On 4/23/18 6:39 PM, Zhu Yanjun wrote:
>> This reverts commit 3b12f73a5c2977153f28a224392fd4729b50d1dc.
>> After long time discussion and investigations, it seems that there
>> is no mem leak. So this patch is reverted.
>> Signed-off-by: Zhu Yanjun <yanjun.zhu@...cle.com>
>> ---
> Well your fix was not for any leaks but just proper labels for
> graceful exits. I don't know which long time discussion
> you are referring but there is no need to revert this change
> unless you see any issue with your change.

As spotted by Dax Moxnes, the patch misses to call rds_ib_dev_put() when exiting normally, only on err exit.


Thxs, Håkon

> 
> Regards,
> Santosh
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html