netdev - Re: [PATCH] net: net_cls: remove a NULL check for css_cls

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 25 Apr 2018 11:00:32 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     roy.qing.li@...il.com
Cc:     lirongqing@...du.com, netdev@...r.kernel.org
Subject: Re: [PATCH] net: net_cls: remove a NULL check for css_cls_state

From: Li RongQing <roy.qing.li@...il.com>
Date: Wed, 25 Apr 2018 16:35:02 +0800

> On 4/20/18, David Miller <davem@...emloft.net> wrote:
>> From: Li RongQing <lirongqing@...du.com>
>> Date: Thu, 19 Apr 2018 12:59:21 +0800
>>
>>> The input of css_cls_state() is impossible to NULL except
>>> cgrp_css_online, so simplify it
>>>
>>> Signed-off-by: Li RongQing <lirongqing@...du.com>
>>
>> I don't view this as an improvement.  Just let the helper always check
>> NULL and that way there are less situations to audit.
>>
> css_cls_state maybe return NULL, but nearly no places check the return
> value with NULL, this seems unreadable.

I saw this email of your's the first few times, you don't need to post
it again.

I still disagree with your analysis, and I do not see your change as
an overall improvement.

Thank you.