netdev - RE: [PATCH net-next] lan78xx: Lan7801 Support for Fixed PHY

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <0573C9D4B793EF43BF95221F2F4CC85153E24D@CHN-SV-EXMX06.mchp-main.com>
Date:   Wed, 25 Apr 2018 19:05:04 +0000
From:   <RaghuramChary.Jallipalli@...rochip.com>
To:     <f.fainelli@...il.com>, <andrew@...n.ch>
CC:     <davem@...emloft.net>, <netdev@...r.kernel.org>,
        <UNGLinuxDriver@...rochip.com>, <Woojung.Huh@...rochip.com>
Subject: RE: [PATCH net-next] lan78xx: Lan7801 Support for Fixed PHY

Hi Florian,
> It still is completely unnecessary, you can do something like the following:
> 
> 	struct phy_device *phydev = netdev->phydev;
> 
> 	phy_disconnect(phydev);
> 	if (phy_is_pseudo_fixed_link(phydev))
> 		fixed_phy_unregister(phydev);
> 
> while netdev->phydev becomes NULL after phy_disconnect(), you retained
> a reference to the original PHY device before disconnecting, in order to
> unregister it. Can you see if that works?
> --
Done. Thanks.

Thanks,
Raghu