lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 25 Apr 2018 07:12:29 +0000 From: Christophe ROULLIER <christophe.roullier@...com> To: Andrew Lunn <andrew@...n.ch> CC: "mark.rutland@....com" <mark.rutland@....com>, "mcoquelin.stm32@...il.com" <mcoquelin.stm32@...il.com>, Alexandre TORGUE <alexandre.torgue@...com>, Peppe CAVALLARO <peppe.cavallaro@...com>, "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>, "linux-arm-kernel@...ts.infradead.org" <linux-arm-kernel@...ts.infradead.org>, "netdev@...r.kernel.org" <netdev@...r.kernel.org> Subject: RE: [PATCH 1/8] net: ethernet: stmmac: add adaptation for stm32mp157c. Hi Andrew, For moment, I've only tested with PHY RGMII, RMII, MII, GMII, I do not have other kind of PHY interface. Normally there is no impact in my glue, the value of syscfg register will be the same for RGMII/ID/TXID/RXID. Do you think that I should add these interfaces in my case ? case PHY_INTERFACE_MODE_RGMII: > + case PHY_INTERFACE_MODE_RGMII_ID: > + case PHY_INTERFACE_MODE_RGMII_RXID: > + case PHY_INTERFACE_MODE_RGMII_TXID: val = SYSCFG_PMCR_ETH_SEL_RGMII; if (dwmac->int_phyclk) val |= SYSCFG_PMCR_ETH_CLK_SEL; pr_debug("SYSCFG init : PHY_INTERFACE_MODE_RGMII\n"); break; Christophe. -----Original Message----- From: Andrew Lunn [mailto:andrew@...n.ch] Sent: mardi 24 avril 2018 17:40 To: Christophe ROULLIER <christophe.roullier@...com> Cc: mark.rutland@....com; mcoquelin.stm32@...il.com; Alexandre TORGUE <alexandre.torgue@...com>; Peppe CAVALLARO <peppe.cavallaro@...com>; devicetree@...r.kernel.org; linux-arm-kernel@...ts.infradead.org; netdev@...r.kernel.org Subject: Re: [PATCH 1/8] net: ethernet: stmmac: add adaptation for stm32mp157c. On Tue, Apr 24, 2018 at 05:01:53PM +0200, Christophe Roullier wrote: > + case PHY_INTERFACE_MODE_RGMII: > + val = SYSCFG_PMCR_ETH_SEL_RGMII; > + if (dwmac->int_phyclk) > + val |= SYSCFG_PMCR_ETH_CLK_SEL; > + pr_debug("SYSCFG init : PHY_INTERFACE_MODE_RGMII\n"); > + break; Hi Christophe What about PHY_INTERFACE_MODE_RGMII_ID, PHY_INTERFACE_MODE_RGMII_RXID and PHY_INTERFACE_MODE_RGMII_TXID. Andrew
Powered by blists - more mailing lists