netdev - Re: [net 1/6] ixgbevf: ensure xdp_ring resources are free'd on error exit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c8aac365-390d-f2df-ceba-4a26fec09b29@cogentembedded.com>
Date:   Wed, 25 Apr 2018 12:25:41 +0300
From:   Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:     Jeff Kirsher <jeffrey.t.kirsher@...el.com>, davem@...emloft.net
Cc:     Colin Ian King <colin.king@...onical.com>, netdev@...r.kernel.org,
        nhorman@...hat.com, sassmann@...hat.com, jogreene@...hat.com
Subject: Re: [net 1/6] ixgbevf: ensure xdp_ring resources are free'd on error
 exit

Hello!

On 4/24/2018 10:29 PM, Jeff Kirsher wrote:

> From: Colin Ian King <colin.king@...onical.com>
> 
> The current error handling for failed resource setup for xdp_ring
> data is a break out of the loop and returning 0 indicated everything
> was OK, when in fact it is not.  Fix this by exiting via the
> error exit label err_setup_tx that will clean up the resources
> correctly and return and error status.

    s/and/an/&

> Detected by CoverityScan, CID#1466879 ("Logically dead code")
> 
> Fixes: 21092e9ce8b1 ("ixgbevf: Add support for XDP_TX action")
> Signed-off-by: Colin Ian King <colin.king@...onical.com>
> Tested-by: Andrew Bowers <andrewx.bowers@...el.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
[...]

MBR, Sergei