netdev - Re: [PATCH net-next 02/10] udp: add gso

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAF=yD-J7=a6cPE_f04yLh1kKYgTTR8OVx7FAnS+gFRGn6CeeHw@mail.gmail.com>
Date:   Thu, 26 Apr 2018 13:49:53 -0400
From:   Willem de Bruijn <willemdebruijn.kernel@...il.com>
To:     Alexander Duyck <alexander.duyck@...il.com>
Cc:     Netdev <netdev@...r.kernel.org>,
        David Miller <davem@...emloft.net>,
        Dimitris Michailidis <dmichail@...gle.com>,
        Willem de Bruijn <willemb@...gle.com>
Subject: Re: [PATCH net-next 02/10] udp: add gso

>>> That way for things like GSO_PARTIAL we can update after segmentation
>>> since there are only going to be 2 segments most likely instead of
>>> multiple MSS sized segments.
>>
>> I don't quite follow. Which two segments?
>
> When we do GSO partial we end up with 2 segments. One really big one
> that is a multiple of MSS and the remainder assuming the frame is odd
> sized. The idea is we can just replicate all of the headers from the
> outer IP header to the inner transport header in hardware so we do all
> the updates based on that assumption and then we do the standard
> segmentation update on the tail skb.

Thanks for the explanation. That is a very cool feature. I clearly hadn't
read the GSO_PARTIAL code closely enough yet.