netdev - Re: [PATCH net-next v2 2/5] bpf: Add IPv6 Segment Routing helpers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <201804261225.iD93Ueq6%fengguang.wu@intel.com>
Date:   Thu, 26 Apr 2018 14:41:19 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Mathieu Xhonneux <m.xhonneux@...il.com>
Cc:     kbuild-all@...org, netdev@...r.kernel.org, dlebrun@...gle.com,
        alexei.starovoitov@...il.com
Subject: Re: [PATCH net-next v2 2/5] bpf: Add IPv6 Segment Routing helpers

Hi Mathieu,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on net-next/master]

url:    https://github.com/0day-ci/linux/commits/Mathieu-Xhonneux/ipv6-sr-introduce-seg6local-End-BPF-action/20180426-082209
config: i386-randconfig-n0-201816 (attached as .config)
compiler: gcc-7 (Debian 7.3.0-16) 7.3.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

All errors (new ones prefixed by >>):

   net/core/filter.o: In function `bpf_push_seg6_encap':
>> net/core/filter.c:3741: undefined reference to `seg6_do_srh_inline'
>> net/core/filter.c:3746: undefined reference to `seg6_do_srh_encap'
>> net/core/filter.c:3757: undefined reference to `seg6_lookup_nexthop'
   net/core/filter.o: In function `____bpf_lwt_seg6_action':
   net/core/filter.c:3856: undefined reference to `seg6_lookup_nexthop'

vim +3741 net/core/filter.c

  3727	
  3728	int bpf_push_seg6_encap(struct sk_buff *skb, u32 type, void *hdr, u32 len)
  3729	{
  3730		int err;
  3731		struct ipv6_sr_hdr *srh = (struct ipv6_sr_hdr *)hdr;
  3732	
  3733		if (!seg6_validate_srh(srh, len))
  3734			return -EINVAL;
  3735	
  3736		switch (type) {
  3737		case BPF_LWT_ENCAP_SEG6_INLINE:
  3738			if (skb->protocol != htons(ETH_P_IPV6))
  3739				return -EBADMSG;
  3740	
> 3741			err = seg6_do_srh_inline(skb, srh);
  3742			break;
  3743		case BPF_LWT_ENCAP_SEG6:
  3744			skb_reset_inner_headers(skb);
  3745			skb->encapsulation = 1;
> 3746			err = seg6_do_srh_encap(skb, srh, IPPROTO_IPV6);
  3747			break;
  3748		default:
  3749			return -EINVAL;
  3750		}
  3751		if (err)
  3752			return err;
  3753	
  3754		ipv6_hdr(skb)->payload_len = htons(skb->len - sizeof(struct ipv6hdr));
  3755		skb_set_transport_header(skb, sizeof(struct ipv6hdr));
  3756	
> 3757		return seg6_lookup_nexthop(skb, NULL, 0);
  3758	}
  3759	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (29340 bytes)