netdev - Re: [PATCH net-next v2 4/5] ipv6: sr: Add seg6local action End.BPF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 27 Apr 2018 10:59:19 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     m.xhonneux@...il.com
Cc:     netdev@...r.kernel.org, dlebrun@...gle.com,
        alexei.starovoitov@...il.com
Subject: Re: [PATCH net-next v2 4/5] ipv6: sr: Add seg6local action End.BPF

From: Mathieu Xhonneux <m.xhonneux@...il.com>
Date: Tue, 24 Apr 2018 18:44:15 +0100

> This patch adds the End.BPF action to the LWT seg6local infrastructure.
> This action works like any other seg6local End action, meaning that an IPv6
> header with SRH is needed, whose DA has to be equal to the SID of the
> action. It will also advance the SRH to the next segment, the BPF program
> does not have to take care of this.

I'd like to see some BPF developers review this change.

But on my side I wonder if, instead of validating the whole thing afterwards,
we should make the helpers accessible by the eBPF program validate the changes
as they are made.