netdev - Re: [PATCH net] tcp: ignore Fast Open on repair mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180427.115037.1333981319439925579.davem@davemloft.net>
Date:   Fri, 27 Apr 2018 11:50:37 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     ycheng@...gle.com
Cc:     netdev@...r.kernel.org, edumazet@...gle.com, ncardwell@...gle.com
Subject: Re: [PATCH net] tcp: ignore Fast Open on repair mode

From: Yuchung Cheng <ycheng@...gle.com>
Date: Wed, 25 Apr 2018 11:33:08 -0700

> The TCP repair sequence of operation is to first set the socket in
> repair mode, then inject the TCP stats into the socket with repair
> socket options, then call connect() to re-activate the socket. The
> connect syscall simply returns and set state to ESTABLISHED
> mode. As a result Fast Open is meaningless for TCP repair.
> 
> However allowing sendto() system call with MSG_FASTOPEN flag half-way
> during the repair operation could unexpectedly cause data to be
> sent, before the operation finishes changing the internal TCP stats
> (e.g. MSS).  This in turn triggers TCP warnings on inconsistent
> packet accounting.
> 
> The fix is to simply disallow Fast Open operation once the socket
> is in the repair mode.
> 
> Reported-by: syzbot <syzkaller@...glegroups.com>
> Signed-off-by: Yuchung Cheng <ycheng@...gle.com>
> Reviewed-by: Neal Cardwell <ncardwell@...gle.com>
> Reviewed-by: Eric Dumazet <edumazet@...gle.com>

Applied and queued up for -stable, thanks Yuchung.