netdev - Re: [Cake] [PATCH iproute2-next v5] Add support for cake qdisc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180427091702.2e91a5dc@xeon-e3>
Date:   Fri, 27 Apr 2018 09:17:02 -0700
From:   Stephen Hemminger <stephen@...workplumber.org>
To:     Toke Høiland-Jørgensen <toke@...e.dk>
Cc:     netdev@...r.kernel.org, cake@...ts.bufferbloat.net
Subject: Re: [Cake] [PATCH iproute2-next v5] Add support for cake qdisc

On Fri, 27 Apr 2018 14:17:06 +0200
Toke Høiland-Jørgensen <toke@...e.dk> wrote:

> +		} else if (strcmp(*argv, "datacentre") == 0) {
> +			interval = 100;
> +			target   =   5;
> +		} else if (strcmp(*argv, "lan") == 0) {
> +			interval = 1000;
> +			target   =   50;
> +		} else if (strcmp(*argv, "metro") == 0) {
> +			interval = 10000;
> +			target   =   500;
> +		} else if (strcmp(*argv, "regional") == 0) {
> +			interval = 30000;
> +			target    = 1500;
> +		} else if (strcmp(*argv, "internet") == 0) {
> +			interval = 100000;
> +			target   =   5000;
> +		} else if (strcmp(*argv, "oceanic") == 0) {
> +			interval = 300000;
> +			target   =  15000;
> +		} else if (strcmp(*argv, "satellite") == 0) {
> +			interval = 1000000;
> +			target   =   50000;
> +		} else if (strcmp(*argv, "interplanetary") == 0) {
> +			interval = 1000000000;
> +			target   =   50000000;
> +

There enough tuning entries of this type, that it would be better
to make a table that can be expanded.

The code should also only allow one of these options. Use duparg()?