netdev - Re: [PATCH V8 net-next 00/14] TLS offload, netdev & MLX5 support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20180427.133412.16008743935367755.davem@davemloft.net>
Date:   Fri, 27 Apr 2018 13:34:12 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     borisp@...lanox.com
Cc:     netdev@...r.kernel.org, saeedm@...lanox.com, davejwatson@...com,
        ktkhai@...tuozzo.com
Subject: Re: [PATCH V8 net-next 00/14] TLS offload, netdev & MLX5 support

From: David Miller <davem@...emloft.net>
Date: Fri, 27 Apr 2018 13:31:47 -0400 (EDT)

> From: Boris Pismenny <borisp@...lanox.com>
> Date: Thu, 26 Apr 2018 09:37:08 +0300
> 
>> This series adds a generic infrastructure to offload TLS crypto to a
>> network devices. It enables the kernel TLS socket to skip encryption and
>> authentication operations on the transmit side of the data path. Leaving
>> those computationally expensive operations to the NIC.
>  ...
> 
> Series applied.
> 
> Assuming no build test issues I will push it out to net-next.

No dice, I'm reverting.

net/tls/tls_sw.c: In function ‘tls_set_sw_offload’:
net/tls/tls_sw.c:1192:22: warning: ‘sw_ctx_rx’ may be used uninitialized in this function [-Wmaybe-uninitialized]
   sw_ctx_rx->sk_poll = sk->sk_socket->ops->poll;
   ~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from ./include/linux/dma-mapping.h:11:0,
                 from ./include/linux/skbuff.h:34,
                 from ./include/net/strparser.h:14,
                 from net/tls/tls_sw.c:41:
./include/linux/scatterlist.h:183:31: warning: ‘sw_ctx_tx’ may be used uninitialized in this function [-Wmaybe-uninitialized]
  prv[prv_nents - 1].page_link = ((unsigned long) sgl | SG_CHAIN)
                               ^
net/tls/tls_sw.c:1051:28: note: ‘sw_ctx_tx’ was declared here
  struct tls_sw_context_tx *sw_ctx_tx;
                            ^~~~~~~~~