netdev - Re: [PATCH net] mlxsw: spectrum_switchdev: Do not remove mrouter port from MDB's ports list

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180427.134517.1688383667846745426.davem@davemloft.net>
Date:   Fri, 27 Apr 2018 13:45:17 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     idosch@...lanox.com
Cc:     netdev@...r.kernel.org, jiri@...lanox.com, nogahf@...lanox.com,
        colin.king@...onical.com, mlxsw@...lanox.com
Subject: Re: [PATCH net] mlxsw: spectrum_switchdev: Do not remove mrouter
 port from MDB's ports list

From: Ido Schimmel <idosch@...lanox.com>
Date: Thu, 26 Apr 2018 11:46:29 +0300

> When IGMP snooping is enabled on a bridge, traffic forwarded by an MDB
> entry should be sent to both ports member in the MDB's ports list and
> mrouter ports.
> 
> In case a port needs to be removed from an MDB's ports list, but this
> port is also configured as an mrouter port, then do not update the
> device so that it will continue to forward traffic through that port.
> 
> Fix a copy-paste error that checked that IGMP snooping is enabled twice
> instead of checking the port's mrouter state.
> 
> Fixes: ded711c87a04 ("mlxsw: spectrum_switchdev: Consider mrouter status for mdb changes")
> Signed-off-by: Ido Schimmel <idosch@...lanox.com>
> Reported-by: Colin King <colin.king@...onical.com>
> Reviewed-by: Nogah Frankel <nogahf@...lanox.com>

Applied and queued up for -stable, thanks.