netdev - Re: [PATCH net-next] net: sch: prio: Set bands to default on delete instead of noop

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAM_iQpUEWBabXXF6SgKNhhPu2Mq+axdJ9RCTDAPJOEGfpw8eNg@mail.gmail.com>
Date:   Fri, 27 Apr 2018 11:20:08 -0700
From:   Cong Wang <xiyou.wangcong@...il.com>
To:     Nogah Frankel <nogahf@...lanox.com>
Cc:     Linux Kernel Network Developers <netdev@...r.kernel.org>,
        David Miller <davem@...emloft.net>,
        Jiri Pirko <jiri@...nulli.us>,
        Jamal Hadi Salim <jhs@...atatu.com>, mlxsw@...lanox.com
Subject: Re: [PATCH net-next] net: sch: prio: Set bands to default on delete
 instead of noop

On Thu, Apr 26, 2018 at 6:32 AM, Nogah Frankel <nogahf@...lanox.com> wrote:
> When a band is created, it is set to the default qdisc, which is
> "invisible" pfifo.


Isn't TCA_DUMP_INVISIBLE for dumping this invisible qdisc?


> However, if a band is set to a qdisc that is later being deleted, it will
> be set to noop qdisc. This can cause a packet loss, while there is no clear
> user indication for it. ("invisible" qdisc are not being shown by default).
> This patch sets a band to the default qdisc, rather then the noop qdisc, on
> delete operation.

It is set to noop historically, may be not reasonable but changing
it could break things.

What's wrong with using TCA_DUMP_INVISIBLE to dump it?