netdev - Re: Request for stable 4.14.x inclusion: net: don't call update

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7485fe73-0c33-e5b4-6c9b-c8c7a359be4a@ehuk.net>
Date:   Fri, 27 Apr 2018 19:43:52 +0100
From:   Eddie Chapman <eddie@...k.net>
To:     Thomas Deutschmann <whissi@...too.org>,
        Greg KH <gregkh@...uxfoundation.org>
Cc:     stable@...r.kernel.org, davem@...emloft.net,
        nicolas.dichtel@...nd.com, netdev@...r.kernel.org
Subject: Re: Request for stable 4.14.x inclusion: net: don't call update_pmtu
 unconditionally

On 27/04/18 19:07, Thomas Deutschmann wrote:
> Hi Greg,
> 
> first, we need to cherry-pick another patch first:
>   
>>  From 52a589d51f1008f62569bf89e95b26221ee76690 Mon Sep 17 00:00:00 2001
>> From: Xin Long <lucien.xin@...il.com>
>> Date: Mon, 25 Dec 2017 14:43:58 +0800
>> Subject: [PATCH] geneve: update skb dst pmtu on tx path
>>
>> Commit a93bf0ff4490 ("vxlan: update skb dst pmtu on tx path") has fixed
>> a performance issue caused by the change of lower dev's mtu for vxlan.
>>
>> The same thing needs to be done for geneve as well.
>>
>> Note that geneve cannot adjust it's mtu according to lower dev's mtu
>> when creating it. The performance is very low later when netperfing
>> over it without fixing the mtu manually. This patch could also avoid
>> this issue.
>>
>> Signed-off-by: Xin Long <lucien.xin@...il.com>
>> Signed-off-by: David S. Miller <davem@...emloft.net>

Oops, I completely missed that the coreos patch doesn't have the geneve 
hunk that is in the original 4.15 patch. I don't load the geneve module 
on my box hence why no problems surfaced on my machine.

Thanks Thomas for the correct instructions. Ignore my message Greg, I'll 
drop back into the shadows where I belong, sorry for the noise!