netdev - Re: [PATCH v5 net-next 3/3] lan78xx: Modify error messages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <597f3ea0-1b71-5a0e-50e1-682797967194@cogentembedded.com>
Date:   Fri, 27 Apr 2018 22:19:55 +0300
From:   Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:     Raghuram Chary J <raghuramchary.jallipalli@...rochip.com>,
        davem@...emloft.net
Cc:     netdev@...r.kernel.org, unglinuxdriver@...rochip.com,
        woojung.huh@...rochip.com
Subject: Re: [PATCH v5 net-next 3/3] lan78xx: Modify error messages

Hello!

On 04/27/2018 09:47 PM, Raghuram Chary J wrote:

> Modify the error messages when phy registration fails.
> 
> Signed-off-by: Raghuram Chary J <raghuramchary.jallipalli@...rochip.com>
> ---
>  drivers/net/usb/lan78xx.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/usb/lan78xx.c b/drivers/net/usb/lan78xx.c
> index 54f8db887e3d..4b930c9faa16 100644
> --- a/drivers/net/usb/lan78xx.c
> +++ b/drivers/net/usb/lan78xx.c
> @@ -2100,14 +2100,14 @@ static struct phy_device *lan7801_phy_init(struct lan78xx_net *dev)
>  		ret = phy_register_fixup_for_uid(PHY_KSZ9031RNX, 0xfffffff0,
>  						 ksz9031rnx_fixup);
>  		if (ret < 0) {
> -			netdev_err(dev->net, "fail to register fixup\n");
> +			netdev_err(dev->net, "fail to register fixup for PHY_KSZ9031RNX\n");

   Could correct "fail" to "failed", while at it.

>  			return NULL;
>  		}
>  		/* external PHY fixup for LAN8835 */
>  		ret = phy_register_fixup_for_uid(PHY_LAN8835, 0xfffffff0,
>  						 lan8835_fixup);
>  		if (ret < 0) {
> -			netdev_err(dev->net, "fail to register fixup\n");
> +			netdev_err(dev->net, "fail to register fixup for PHY_LAN8835\n");

   Likewise.

[...]

MBR, Sergei