netdev - Re: [PATCH bpf-next] bpf: fix xdp_generic for bpf_adjust

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f5306b4e-e1e7-6b3e-5048-12a0011b389a@iogearbox.net>
Date:   Fri, 27 Apr 2018 11:11:40 +0200
From:   Daniel Borkmann <daniel@...earbox.net>
To:     "Nikita V. Shirokov" <tehnerd@...nerd.com>,
        Alexei Starovoitov <ast@...nel.org>,
        "David S . Miller" <davem@...emloft.net>
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH bpf-next] bpf: fix xdp_generic for bpf_adjust_tail usecase

On 04/25/2018 04:15 PM, Nikita V. Shirokov wrote:
>  when bpf_adjust_tail was introduced for generic xdp, it changed skb's tail
>  pointer, so it was pointing to the new  "end of the packet". however skb's
>  len field wasn't properly modified, so on the wire ethernet frame had
>  original (or even bigger, if adjust_head was used) size. this diff is fixing
>  this.
> 
> Fixes: 198d83bb3 (" bpf: make generic xdp compatible w/
> bpf_xdp_adjust_tail")
> 
> Signed-off-by: Nikita V. Shirokov <tehnerd@...nerd.com>

Applied yesterday to bpf-next (and now in net-next), thanks Nikita!