netdev - Re: [bpf-next PATCH v2 3/3] bpf: selftest additions for SOCKHASH

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3edef81b-5529-be5f-3a95-7565619bd347@gmail.com>
Date:   Sat, 28 Apr 2018 20:43:57 -0700
From:   John Fastabend <john.fastabend@...il.com>
To:     Alexei Starovoitov <alexei.starovoitov@...il.com>
Cc:     ast@...nel.org, daniel@...earbox.net, netdev@...r.kernel.org
Subject: Re: [bpf-next PATCH v2 3/3] bpf: selftest additions for SOCKHASH

On 04/27/2018 05:10 PM, Alexei Starovoitov wrote:
> On Fri, Apr 27, 2018 at 04:24:43PM -0700, John Fastabend wrote:
>> This runs existing SOCKMAP tests with SOCKHASH map type. To do this
>> we push programs into include file and build two BPF programs. One
>> for SOCKHASH and one for SOCKMAP.
>>
>> We then run the entire test suite with each type.
>>
>> Signed-off-by: John Fastabend <john.fastabend@...il.com>
>> ---
>>  tools/testing/selftests/bpf/Makefile             |    3 
>>  tools/testing/selftests/bpf/test_sockhash_kern.c |    4 
>>  tools/testing/selftests/bpf/test_sockmap.c       |   27 +-
>>  tools/testing/selftests/bpf/test_sockmap_kern.c  |  340 ----------------------
>>  tools/testing/selftests/bpf/test_sockmap_kern.h  |  340 ++++++++++++++++++++++
>>  5 files changed, 368 insertions(+), 346 deletions(-)
>>  create mode 100644 tools/testing/selftests/bpf/test_sockhash_kern.c
>>  create mode 100644 tools/testing/selftests/bpf/test_sockmap_kern.h
> 
> Looks like it was mainly a rename of test_sockmap_kern.c into .h
> but commit doesn't show it as such.
> Can you redo it with 'git mv' ?
> 

Sure, my scripts didn't have the --find-renames. Anyways should be
better now in v3. Also pushed tools updates into selftest patch.

Thanks,
John