netdev - Re: [PATCH v4 net-next 0/2] tcp: mmap: rework zerocopy receive

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180429.213417.1622456092178936722.davem@davemloft.net>
Date:   Sun, 29 Apr 2018 21:34:17 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     edumazet@...gle.com
Cc:     netdev@...r.kernel.org, luto@...nel.org,
        linux-kernel@...r.kernel.org, linux-mm@...ck.org,
        ka-cheong.poon@...cle.com, eric.dumazet@...il.com
Subject: Re: [PATCH v4 net-next 0/2] tcp: mmap: rework zerocopy receive

From: Eric Dumazet <edumazet@...gle.com>
Date: Fri, 27 Apr 2018 08:58:07 -0700

> syzbot reported a lockdep issue caused by tcp mmap() support.
> 
> I implemented Andy Lutomirski nice suggestions to resolve the
> issue and increase scalability as well.
> 
> First patch is adding a new getsockopt() operation and changes mmap()
> behavior.
> 
> Second patch changes tcp_mmap reference program.
> 
> v4: tcp mmap() support depends on CONFIG_MMU, as kbuild bot told us.
> 
> v3: change TCP_ZEROCOPY_RECEIVE to be a getsockopt() option
>     instead of setsockopt(), feedback from Ka-Cheon Poon
> 
> v2: Added a missing page align of zc->length in tcp_zerocopy_receive()
>     Properly clear zc->recv_skip_hint in case user request was completed.

Looks great, series applied, thanks Eric.