netdev - Re: [PATCH] net: gemini: fix gmac_start

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACRpkdaR=wqCfRmyqpLufYoLbFHr9ixy6gZq6MqdaGdaXPiQzQ@mail.gmail.com>
Date:   Mon, 30 Apr 2018 11:17:19 +0200
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Luc Van Oostenryck <luc.vanoostenryck@...il.com>
Cc:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Hans Ulli Kroll <ulli.kroll@...glemail.com>,
        Linux ARM <linux-arm-kernel@...ts.infradead.org>,
        netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH] net: gemini: fix gmac_start_xmit()'s return type

On Tue, Apr 24, 2018 at 3:16 PM, Luc Van Oostenryck
<luc.vanoostenryck@...il.com> wrote:

> The method ndo_start_xmit() is defined as returning an 'netdev_tx_t',
> which is a typedef for an enum type, but the implementation in this
> driver returns an 'int'.
>
> Fix this by returning 'netdev_tx_t' in this driver too.
>
> Signed-off-by: Luc Van Oostenryck <luc.vanoostenryck@...il.com>

Reviewed-by: Linus Walleij <linus.walleij@...aro.org>

Thanks for fixing this!
Linus Walleij