netdev - Re: [PATCH net-next v6] Add Common Applications Kept Enhanced (cake) qdisc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4ec8da81-8671-f434-bada-27088b09ce7b@gmail.com>
Date:   Tue, 1 May 2018 12:12:45 -0700
From:   Eric Dumazet <eric.dumazet@...il.com>
To:     Toke Høiland-Jørgensen <toke@...e.dk>,
        Eric Dumazet <eric.dumazet@...il.com>,
        Dave Taht <dave.taht@...il.com>,
        Cong Wang <xiyou.wangcong@...il.com>
Cc:     Linux Kernel Network Developers <netdev@...r.kernel.org>,
        Cake List <cake@...ts.bufferbloat.net>
Subject: Re: [PATCH net-next v6] Add Common Applications Kept Enhanced (cake)
 qdisc

On 05/01/2018 11:53 AM, Toke Høiland-Jørgensen wrote:

> *sigh* - can do, I guess. Though I'm not sure what that is going to
> accomplish, exactly?

I guess that nobody really wants to really review Cake if
it is a file with 2700 lines of code and hundreds of variables/tunables.

Sure, we have big files in networking land, as a result of thousands of changes.

If you split it, then maybe the work can be split among reviewers as a result.

Or maybe David Miller can simply merge your patch as is, and hope for the best,
I really do not know.

It seems you guys spent years/months on work on this stuff, so what is the big deal
about presenting your work in the best possible way ?

Thanks.