netdev - Re: [PATCH bpf-next 0/3] bpf: cleanups on managing subprog information

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180501222257.cogbkcsncrmg54p5@ast-mbp>
Date:   Tue, 1 May 2018 15:22:59 -0700
From:   Alexei Starovoitov <alexei.starovoitov@...il.com>
To:     Jiong Wang <jiong.wang@...ronome.com>
Cc:     borkmann@...earbox.net, ecree@...arflare.com,
        netdev@...r.kernel.org, oss-drivers@...ronome.com
Subject: Re: [PATCH bpf-next 0/3] bpf: cleanups on managing subprog
 information

On Mon, Apr 30, 2018 at 06:28:13PM -0400, Jiong Wang wrote:
> 
> There is no functional change by this patch set.
> No bpf selftest regression found after this patch set.

I was about to apply them, but there is a regression:
[   27.773899] ==================================================================
[   27.774802] BUG: KASAN: slab-out-of-bounds in do_jit+0x5499/0x6020
[   27.775559] Read of size 4 at addr ffff8801197fe7f4 by task test_verifier/344
[   27.776412]
[   27.776607] CPU: 3 PID: 344 Comm: test_verifier Not tainted 4.17.0-rc2-00451-geb43cb64a84a #943
[   27.777644] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.9.3-1.el7.centos 04/01/2014
[   27.778894] Call Trace:
[   27.779217]  dump_stack+0x5b/0x8b
[   27.779675]  ? do_jit+0x5499/0x6020
[   27.780148]  print_address_description+0x73/0x290
[   27.780716]  ? do_jit+0x5499/0x6020
[   27.781152]  kasan_report+0x22b/0x350
[   27.781602]  do_jit+0x5499/0x6020
[   27.782020]  ? __mod_node_page_state+0xa2/0xd0
[   27.782557]  ? jit_fill_hole+0x20/0x20
[   27.783019]  ? ___slab_alloc+0x3e7/0x4d0
[   27.783498]  ? kasan_unpoison_shadow+0x30/0x40
[   27.784042]  ? kasan_kmalloc+0xa0/0xd0
[   27.784497]  ? __kmalloc+0x109/0x200
[   27.784931]  ? bpf_int_jit_compile+0x7ac/0xab0
[   27.785475]  bpf_int_jit_compile+0x2b6/0xab0
[   27.786001]  ? do_jit+0x6020/0x6020
[   27.786428]  ? kasan_kmalloc+0xa0/0xd0
[   27.786885]  bpf_check+0x2c05/0x4c40
[   27.787346]  ? fixup_bpf_calls+0x1140/0x1140
[   27.787865]  ? kasan_unpoison_shadow+0x30/0x40
[   27.788406]  ? kasan_kmalloc+0xa0/0xd0
[   27.788865]  ? memset+0x1f/0x40
[   27.789255]  ? bpf_obj_name_cpy+0x2d/0x200
[   27.789750]  bpf_prog_load+0xb07/0xeb0

simply running test_verifier with JIT and kasan on.