netdev - Re: [PATCH] ipv6: Allow non-gateway ECMP for IPv6

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <89497565-f1e6-a916-70d3-dfc7efa7a7e4@gmail.com>
Date:   Mon, 30 Apr 2018 20:59:10 -0600
From:   David Ahern <dsahern@...il.com>
To:     Thomas Winter <Thomas.Winter@...iedtelesis.co.nz>,
        netdev@...r.kernel.org
Cc:     "David S. Miller" <davem@...emloft.net>,
        Alexey Kuznetsov <kuznet@....inr.ac.ru>,
        Hideaki YOSHIFUJI <yoshfuji@...ux-ipv6.org>,
        Ido Schimmel <idosch@...lanox.com>
Subject: Re: [PATCH] ipv6: Allow non-gateway ECMP for IPv6

On 4/30/18 3:15 PM, Thomas Winter wrote:
> It is valid to have static routes where the nexthop
> is an interface not an address such as tunnels.
> For IPv4 it was possible to use ECMP on these routes
> but not for IPv6.
> 
> Signed-off-by: Thomas Winter <Thomas.Winter@...iedtelesis.co.nz>
> Cc: David Ahern <dsahern@...il.com>
> Cc: "David S. Miller" <davem@...emloft.net>
> Cc: Alexey Kuznetsov <kuznet@....inr.ac.ru>
> Cc: Hideaki YOSHIFUJI <yoshfuji@...ux-ipv6.org>
> ---
>  include/net/ip6_route.h | 3 +--
>  net/ipv6/ip6_fib.c      | 3 ---
>  2 files changed, 1 insertion(+), 5 deletions(-)
> 

Interesting. Existing code inserts the dev nexthop as a separate route.

Change looks good to me.

Acked-by: David Ahern <dsahern@...il.com>