netdev - Re: [PATCH net-next V2] cls_flower: Support multiple masks per priority

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180501.141437.1748996416481929177.davem@davemloft.net>
Date:   Tue, 01 May 2018 14:14:37 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     paulb@...lanox.com
Cc:     jiri@...lanox.com, xiyou.wangcong@...il.com, jhs@...atatu.com,
        netdev@...r.kernel.org, kliteyn@...lanox.com, roid@...lanox.com,
        shahark@...lanox.com, markb@...lanox.com, ogerlitz@...lanox.com
Subject: Re: [PATCH net-next V2] cls_flower: Support multiple masks per
 priority

From: Paul Blakey <paulb@...lanox.com>
Date: Mon, 30 Apr 2018 14:28:30 +0300

> Currently flower doesn't support inserting filters with different masks
> on a single priority, even if the actual flows (key + mask) inserted
> aren't overlapping, as with the use case of offloading openvswitch
> datapath flows. Instead one must go up one level, and assign different
> priorities for each mask, which will create a different flower
> instances.
> 
> This patch opens flower to support more than one mask per priority,
> and a single flower instance. It does so by adding another hash table
> on top of the existing one which will store the different masks,
> and the filters that share it.
> 
> The user is left with the responsibility of ensuring non overlapping
> flows, otherwise precedence is not guaranteed.
> 
> Signed-off-by: Paul Blakey <paulb@...lanox.com>
> Signed-off-by: Jiri Pirko <jiri@...lanox.com>
> ---
> 
> Changes:
> V1 -> V2: in fl_init, removed unnessecry err variable, just return direct result instead.
>           in fl_mask_range, removed extra new line.
>           commit msg, spelling.

Applied, thanks.